use .null? to test NULL pointer returns#420
Merged
Merged
Conversation
we were using `.nil?` in a couple of cases see #419 thanks dloebl
Member
Author
|
@dloebl I added your coffee GIF to the samples, I hope that's OK. If anyone could double-check that I got all the possible null pointers, that'd be great. |
dloebl
reviewed
Jul 17, 2025
Thanks! That's fine. It's a public domain (CC0) image I got from here and altered some bytes to make it invalid: https://pixabay.com/gifs/coffee-cup-mug-pixel-art-steam-19613
Looks good to me! I've searched through the code as well and wasn't able to find other instances |
dloebl
approved these changes
Jul 17, 2025
Member
Author
|
\o/ thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we were using
.nil?in a couple of casessee #419
thanks dloebl